2216 - 3 #280
2216 - 3 #280
Conversation
2216/3/assets/stylesheets/style.scss
Outdated
|
|
||
| .error_message { | ||
| padding-top: 3%; | ||
| color: red |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
Color red should be written in hexadecimal form as #ff0000
Color literals like red should only be used in variable declarations; they should be referred to via variable everywhere else.
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| .error_message { | ||
| padding-top: 3%; |
There was a problem hiding this comment.
Properties should be ordered color, padding-top
2216/3/assets/stylesheets/style.scss
Outdated
| width: 50% | ||
| } | ||
|
|
||
| .error_message { |
There was a problem hiding this comment.
Selector error_message should be written in lowercase with hyphens
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| #address { | ||
| width: 50% |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
2216/3/assets/stylesheets/style.scss
Outdated
| width: 30% | ||
| } | ||
|
|
||
| #address { |
2216/3/assets/stylesheets/style.scss
Outdated
| h1 { | ||
| font-size: 200%; | ||
| padding-top: 1%; | ||
| color: #fbffc9; |
There was a problem hiding this comment.
Color literals like #fbffc9 should only be used in variable declarations; they should be referred to via variable everywhere else.
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| h1 { | ||
| font-size: 200%; |
There was a problem hiding this comment.
Properties should be ordered color, font-size, padding-top
2216/3/assets/stylesheets/style.scss
Outdated
| color: #fbffc9; | ||
| } | ||
|
|
||
| main, header, footer { |
There was a problem hiding this comment.
Each selector in a comma sequence should be on its own single line
2216/3/assets/stylesheets/style.scss
Outdated
|
|
||
| .copyright { | ||
| padding: 2%; | ||
| color: #fbffc9; |
There was a problem hiding this comment.
Color literals like #fbffc9 should only be used in variable declarations; they should be referred to via variable everywhere else.
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| .copyright { | ||
| padding: 2%; |
There was a problem hiding this comment.
Properties should be ordered color, padding
2216/3/assets/stylesheets/style.scss
Outdated
|
|
||
| .error_message { | ||
| padding-top: 3%; | ||
| color: red |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
Color red should be written in hexadecimal form as #ff0000
Color literals like red should only be used in variable declarations; they should be referred to via variable everywhere else.
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| .error_message { | ||
| padding-top: 3%; |
There was a problem hiding this comment.
Properties should be ordered color, padding-top
2216/3/assets/stylesheets/style.scss
Outdated
| width: 50% | ||
| } | ||
|
|
||
| .error_message { |
There was a problem hiding this comment.
Selector error_message should be written in lowercase with hyphens
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| #address { | ||
| width: 50% |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
2216/3/assets/stylesheets/style.scss
Outdated
| width: 30% | ||
| } | ||
|
|
||
| #address { |
2216/3/assets/stylesheets/style.scss
Outdated
| h1 { | ||
| font-size: 200%; | ||
| padding-top: 1%; | ||
| color: #fbffc9; |
There was a problem hiding this comment.
Color literals like #fbffc9 should only be used in variable declarations; they should be referred to via variable everywhere else.
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| h1 { | ||
| font-size: 200%; |
There was a problem hiding this comment.
Properties should be ordered color, font-size, padding-top
2216/3/assets/stylesheets/style.scss
Outdated
| color: #fbffc9; | ||
| } | ||
|
|
||
| main, header, footer { |
There was a problem hiding this comment.
Each selector in a comma sequence should be on its own single line
2216/3/assets/stylesheets/style.scss
Outdated
|
|
||
| .copyright { | ||
| padding: 2%; | ||
| color: #fbffc9; |
There was a problem hiding this comment.
Color literals like #fbffc9 should only be used in variable declarations; they should be referred to via variable everywhere else.
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| .copyright { | ||
| padding: 2%; |
There was a problem hiding this comment.
Properties should be ordered color, padding
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| .error-message { | ||
| padding-top: 3%; |
There was a problem hiding this comment.
Properties should be ordered color, padding-top
2216/3/assets/stylesheets/style.scss
Outdated
| padding-top: 5%; | ||
| } | ||
|
|
||
| .look_sub { |
There was a problem hiding this comment.
Selector look_sub should be written in lowercase with hyphens
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| table { | ||
| border-collapse: collapse; |
There was a problem hiding this comment.
Properties should be ordered border, border-collapse, margin
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| h1 { | ||
| margin: 0; |
There was a problem hiding this comment.
Properties should be ordered color, font-size, margin, padding, padding-top
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| .copyright { | ||
| padding: 2%; |
There was a problem hiding this comment.
Properties should be ordered color, padding
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| main{ | ||
| width: 100%; |
There was a problem hiding this comment.
Properties should be ordered background-color, height, text-align, width
2216/3/assets/stylesheets/style.scss
Outdated
| text-align: center; | ||
| } | ||
|
|
||
| main{ |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| footer { | ||
| position: fixed; |
There was a problem hiding this comment.
Properties should be ordered background-color, bottom, height, margin, padding, position, text-align, width
2216/3/assets/stylesheets/style.scss
Outdated
| } | ||
|
|
||
| body { | ||
| margin: 0; |
There was a problem hiding this comment.
Properties should be ordered background-color, height, margin, padding, width
2216/3/assets/stylesheets/style.scss
Outdated
| $table-color: rgb(0, 0, 0); | ||
|
|
||
| html { | ||
| position: relative; |
There was a problem hiding this comment.
Properties should be ordered background-color, height, min-height, position, width
Номер
2216
Номер задания
3
Ссылка на видео с демо
https://www.youtube.com/watch?v=UrSibM8d2Dw
Комментарии